Fix Framework\Data\Collection::each() method #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshdifabio
reviewed
Nov 15, 2016
| foreach ($args->_items as $k => $item) { | ||
| $args->_items[$k] = call_user_func($objMethod, $item); | ||
| foreach ($this->getItems() as $item) { | ||
| call_user_func_array([$item, $objMethod], $args); |
There was a problem hiding this comment.
call_user_func_array is quite slow compared to argument unpacking[1].
This should probably be changed to:
$item->$objMethod(...$args);There was a problem hiding this comment.
Good point, updated the PR.
|
Additional enhancement: in order to avoid surprising behavior allow passing a |
|
Unfortunately I can't make the tests pass because:
To fix the integration tests they just need to be rerun at a different time when the service happens to be up and running, and to fix the static test the PSR2 code sniffer rule needs to be fixed. |
|
@Vinai thank you for your contribution to Magento 2 project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
\Magento\Framework\Data\Collection::each()sadly is completely broken, as it iterates over$args->_itemsinstead of the collection items.This PR add test coverage and fixes the method.